Skip to content

fix(trace-viewer): Prevent dropping non-files #38363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(trace-viewer): Prevent dropping non-files #38363

wants to merge 1 commit into from
+5 −1

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Nov 29, 2025 •
edited
Loading

Do not show drop target when not dragging files (e.g. text)

Recording 2025-11-29 112829

Closes: #38361

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

Test results for "MCP"

2 failed
❌ [webkit] › mcp/config.spec.ts:62 › browserName @mcp-ubuntu-latest
❌ [webkit] › mcp/launch.spec.ts:113 › isolated context @mcp-ubuntu-latest

2608 passed, 116 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2025

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-2

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-base-url.spec.ts:37 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:321 › reuse launch › should work with clock emulation `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-history.spec.ts:55 › page.goBack should work for file urls `@webkit-ubuntu-22.04-node18`
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:146 › should upload large file `@webkit-ubuntu-22.04-node18`

40328 passed, 787 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Drop target stays visible when accidentally dragging and dropping text into trace viewer

2 participants

@cpAdm @pavelfeldman